Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Message-ID: <4E197B44.3060200@apache.org>
Date: Sun, 10 Jul 2011 11:13:24 +0100
From: Mark Thomas <markt@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB;
 rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: Sporadic failures in TestCometProcessor
References: <4E1970B1.9050201@kippdata.de>
In-Reply-To: <4E1970B1.9050201@kippdata.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 10/07/2011 10:28, Rainer Jung wrote:
> I get sporadic failures in TestCometProcessor for NIO. They are due to
> the Servlet reading two or more of the PING tokens during a single read
> event call. The loop
> 
>                 while (is.available() > 0) {
>                     is.read();
>                     count ++;
>                 }
> 
> then e.g. consumes PINGPING instead of PING and writes back "READ: 8 bytes".
> 
> Is this an error in the test case, e.g. if the chunks come in quickly
> enough is it OK, that they might get combined into a single read event?
> If so, we might want to add a little sleep in between sending the PING
> lines.

There is already a 1000ms sleep between sending the PINGs. That should
be enough to keep them separate.

Have you always seen these since that test was introduced or is this
something new?

As an aside, I have noticed that running the unit tests on a heavily
loaded box can trigger various timing related failures.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org