Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 65BE7760C for ; Wed, 20 Jul 2011 19:41:45 +0000 (UTC) Received: (qmail 34054 invoked by uid 500); 20 Jul 2011 19:41:44 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 33763 invoked by uid 500); 20 Jul 2011 19:41:43 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 33754 invoked by uid 99); 20 Jul 2011 19:41:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 19:41:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jul 2011 19:41:41 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 465A623888CB for ; Wed, 20 Jul 2011 19:41:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1148915 - in /tomcat/trunk: java/org/apache/jasper/compiler/Compiler.java webapps/docs/changelog.xml Date: Wed, 20 Jul 2011 19:41:19 -0000 To: dev@tomcat.apache.org From: markt@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110720194120.465A623888CB@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: markt Date: Wed Jul 20 19:41:18 2011 New Revision: 1148915 URL: http://svn.apache.org/viewvc?rev=1148915&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51532 JSP files with dependencies in JARs were recompiled on every access leading to poor performance. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java?rev=1148915&r1=1148914&r2=1148915&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java (original) +++ tomcat/trunk/java/org/apache/jasper/compiler/Compiler.java Wed Jul 20 19:41:18 2011 @@ -494,7 +494,13 @@ public abstract class Compiler { while (it.hasNext()) { Entry include = it.next(); try { - URL includeUrl = ctxt.getResource(include.getKey()); + String key = include.getKey(); + URL includeUrl; + if (key.startsWith("jar:")) { + includeUrl = new URL(key); + } else { + includeUrl = ctxt.getResource(include.getKey()); + } if (includeUrl == null) { return true; } Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1148915&r1=1148914&r2=1148915&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Wed Jul 20 19:41:18 2011 @@ -93,6 +93,14 @@ + + + + 51532: JSP files with dependencies in JARs were recompiled on + every access leading to poor performance. (markt) + + + --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org