tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51468] Redirect Valve
Date Wed, 06 Jul 2011 04:41:47 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468

--- Comment #11 from Sergey Ushakov <ushakov@int.com.ru> 2011-07-06 04:41:47 UTC ---
(In reply to comment #9)
> I am struggling to see the benefit of this Valve compared to the urlrewrite,
> particularly given the features that urlrewrite has compared to this patch.

Well, let's consider a task of mapping/redirecting a Tomcat app to a virtual
directory at a front-end server.

To start with, it is an administrative task, not a developer's one, so the
app's WEB-INF does not look the right place to set it up. The server admin is
not likely to be happy tinkering with the war file or the unpacked folder every
time the developer issues a new version of the app.

The next place to consider for a filter is the the global web.xml or host-level
web.xml. This is likely to do the job, but the fact that the appropriate filter
is going to be instantiated in multiple useless copies for every app, makes the
whole construct strange-looking too.

So a valve looks the most straightforward approach to do the job...

(In reply to comment #10)
> I'm sure it would be useful for /some/ people to incorporate all kinds of
> things from other projects into Tomcat, but it's not really appropriate if they
> already exist, are well-known, and well-supported.

Well, to my mind it's not incorporating existing functionality from other
projects into Tomcat, but rather adding something new and missing. This first
implementation maybe does not look great, but it may eventually get more flesh,
as new requirements get outlined by the practice...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message