Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.212.45 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=PX8K7kL68EVQJkUJwsA8lrm9SnNqDGbX4D44xrsVbJIvOTkEmQeyjFiGbdBNbfUDOI
         VVQt5d2x0PmUfchfHzi0fzX8X0ggmBJbM+eaqftttlGX6HM0tz7JEh/nWPvn2K7amybB
         e4//18Fnx1bHzsAIvJ1Dy3eYUWIjlv/fAiYiw=
MIME-Version: 1.0
In-Reply-To: <20110622183042.3EDE22388A3D@eris.apache.org>
References: <20110622183042.3EDE22388A3D@eris.apache.org>
Date: Thu, 23 Jun 2011 02:50:28 +0400
Message-ID: <BANLkTimM8K=FUx0U6egJwsuWjZ9wEhkf-Q@mail.gmail.com>
Subject: Re: svn commit: r1138573 - in /tomcat/trunk:
 java/org/apache/catalina/startup/Tomcat.java
 webapps/docs/changelog.xml
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2011/6/22  <markt@apache.org>:
> Author: markt
> Date: Wed Jun 22 18:30:41 2011
> New Revision: 1138573
>
> URL: http://svn.apache.org/viewvc?rev=3D1138573&view=3Drev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D51418
> Provide more control over Context creation when embedding Tomcat.
> Based on a patch by Benson Margulies.
>
> Modified:
> =A0 =A0tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
> =A0 =A0tomcat/trunk/webapps/docs/changelog.xml
>

> + =A0 =A0public String noDefaultWebXmlPath() {
> + =A0 =A0 =A0 =A0return "org/apache/catalin/startup/NO_DEFAULT_XML";
> + =A0 =A0}

A typo in the above constant does not prevent it from working, but
somehow bugs me.

Searching for the string finds 4 places where it is used literally.

And now it becomes part of API.

Maybe
1) s/catalin/catalina/
2) add it to o.a.c.startup.Constants, e.g. named as NoDefaultWebXml
3) use the value to short-circuit
ContextConfig#getWebXmlSource(defaultWebXml, baseDir) to return null

An alternative to 2)+3) is to put the constant into
DefaultWebXmlListener, but I like 2)+3) better.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org