tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck
Date Mon, 27 Jun 2011 16:06:52 GMT

--- Comment #21 from Konstantin Prei├čer <> 2011-06-27 16:06:52 UTC ---
Created attachment 27213
Small patch to update C2BConverter

Hi Mark,

(In reply to comment #19)
> My bad. I mis-read the patch (too  much time working with Eclipse where the old
> and new versions are the other way around). Your patch is fine.

> Yep - I missed that too. I'll add that shortly.


Well, I don't mean to be annoying or something, but.. It seems that you forgot
to convert the aliases to lower-case before adding them to the Map, which also
would cause "utf8" not to work. ;-)

May I suggest to also update o.a.tomcat.util.buf.C2BConverter to use a Charset
(because it seems this is used when calling HttpServletResponse.getWriter())?
Please see attached (small) patch.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.
To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message