tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck
Date Mon, 27 Jun 2011 14:40:57 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400

--- Comment #18 from Konstantin Prei├čer <preissa@web.de> 2011-06-27 14:40:57 UTC ---
Hi Mark,

does the patch not correctly address DoS and charset misses because I didn't
use Locale.US? (Nothing would be added to the Map after initialization, so I
can't see a DoS danger there or how it would not cache misses (besides some
"false-positives" with incorrect charset strings in other Locales)).

However, I see that the patch applied to trunk doesn't add the charset aliases
to the Map, which means Charset strings like "utf8" don't work anymore, but
they worked before that change, because Charset.forName or new String(byte[],
String charsetName) allow charset aliases to be used as encoding names. That is
why I also added the aliases to the Map.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message