tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51400] Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck
Date Mon, 27 Jun 2011 14:46:55 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51400

--- Comment #19 from Mark Thomas <markt@apache.org> 2011-06-27 14:46:55 UTC ---
(In reply to comment #18)
> Hi Mark,
> 
> does the patch not correctly address DoS and charset misses because I didn't
> use Locale.US?

My bad. I mis-read the patch (too  much time working with Eclipse where the old
and new versions are the other way around). Your patch is fine.

> However, I see that the patch applied to trunk doesn't add the charset aliases
> to the Map, which means Charset strings like "utf8" don't work anymore, but
> they worked before that change, because Charset.forName or new String(byte[],
> String charsetName) allow charset aliases to be used as encoding names. That is
> why I also added the aliases to the Map.

Yep - I missed that too. I'll add that shortly.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message