tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51142] Offer possible resolution of StringIndexOutOfBoundsException in Request.updateCounters when AJP packetSize is too small.
Date Sat, 04 Jun 2011 07:14:55 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51142

--- Comment #5 from asfbugzilla-m@eghm.net 2011-06-04 07:14:55 UTC ---
(In reply to comment #4)
> No, you missed the key point in my review comment. Putting a try/catch around
> the point where the error is first seen is the wrong approach. The right
> approach is detecting when the packet length > buffer length and taking the
> appropriate action at that point (500 response, log message etc.)

Thanks, but the try catch block is not around where the error is first seen. 
Depending how you count the patch is for the 3rd or 4th apache class up from
where the exception occurs.  Just below two other try catch blocks (all in the
same method) of which this one is nearly identical to.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message