tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: Overhauling setclasspath.(bat|sh)?
Date Tue, 21 Jun 2011 09:40:30 GMT
2011/6/20 Rainer Jung <rainer.jung@kippdata.de>:
> 1) Renaming
>
> Since quite some time now the setclasspath script doesn't have anything
> to do with setting a class path. It only searches for JRE / JDK and sets
> up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS.
>
> So it would be more correct to call it checkjava.sh or setupjava.sh or
> whatever.
>
> Do you think it's too late for TC 7 to rename the script?
>
> Good ideas for a new name?
>

The name may be mentioned in mailing list archives or elsewhere.
I do not think it is worth renaming, but won't oppose it.

> 2) Removing BASEDIR
>
> In addition it contains a validity check for BASEDIR. This is bogus:
> whereever setclasspath is sources, we directly before set BASEDIR to the
> path from which we source setclasspath. In addition, apart from the
> validity check, BASEDIR is never ever used.

It is used:
set "JAVA_ENDORSED_DIRS=%BASEDIR%\endorsed"

but given that it always is equal to CATALINA_HOME I think it is OK to
replace it with CATALINA_HOME.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message