tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Caldarale, Charles R" <Chuck.Caldar...@unisys.com>
Subject RE: svn commit: r1132367 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml
Date Mon, 06 Jun 2011 17:43:08 GMT
> From: Mark Thomas [mailto:markt@apache.org] 
> Subject: Re: svn commit: r1132367 - in /tomcat/trunk: 
> java/org/apache/coyote/http11/Http11AprProcessor.java 
> webapps/docs/changelog.xml

> On 06/06/2011 09:01, Remy Maucherat wrote:
> > I don't understand, the code reads:
> > sendfileData = new AprEndpoint.SendfileData();
> > sendfileData.fileName = fileName;
> > sendfileData.start = ((Long) request.getAttribute(
> >  	"org.apache.tomcat.sendfile.start")).longValue();
> > sendfileData.end = ((Long) request.getAttribute(
> > 	"org.apache.tomcat.sendfile.end")).longValue() - sendfileData.pos; 
> > 
> > So how can sendfileData.pos not be 0 here ?

> Because when the DefaultServlet handles a range request start may be
> non-zero. (line 1658 in trunk)

That's not the issue; the question is how could sendFileData.pos be non-zero in an object
that was just instantiated from a class that has no explicit constructor?

 - Chuck


THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus
for use only by the intended recipient. If you received this in error, please contact the
sender and delete the e-mail and its attachments from all computers.

Mime
View raw message