tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r1141388 - /tomcat/native/trunk/native/src/sslcontext.c
Date Thu, 30 Jun 2011 07:12:11 GMT
On 06/30/2011 08:43 AM, Konstantin Kolinko wrote:
> 2011/6/30<mturk@apache.org>:
>> Author: mturk
>> Date: Thu Jun 30 04:18:36 2011
>> New Revision: 1141388
>>
>> URL: http://svn.apache.org/viewvc?rev=1141388&view=rev
>> Log:
>> Fix BZ51437 by trying to load the DER cerificate if pem load error was PEM_R_NO_START_LINE
>>
>> Modified:
>>     tomcat/native/trunk/native/src/sslcontext.c
>>
>
>> -        cb_data->password[0] = '\0';
>
> The above line inside the loop in the old code - I guess it was retrying
> without a password. With your change that retry is gone.
>
> Is that OK?
>

Password callback is usable only in non service modes
since in service mode there's no gui. User is suppose to
enter the correct password first time.
In case the cert is invalid, retry will cause JVM core,
so it's either one or other. I vote for no core behavior :)




Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message