tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1140467 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Tue, 28 Jun 2011 07:41:26 GMT
On 28/06/2011 08:38, markt@apache.org wrote:
> Author: markt
> Date: Tue Jun 28 07:38:48 2011
> New Revision: 1140467
> 
> URL: http://svn.apache.org/viewvc?rev=1140467&view=rev
> Log:
> Updated patch
> 
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt
> 
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1140467&r1=1140466&r2=1140467&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jun 28 07:38:48 2011
> @@ -151,18 +151,10 @@ PATCHES PROPOSED TO BACKPORT:
>  
>  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51400
>    Avoid jvm bottleneck on String/byte[] conversion currently affecting a user
> -  https://issues.apache.org/bugzilla/attachment.cgi?id=27214
> +  https://issues.apache.org/bugzilla/attachment.cgi?id=27219
>    Based on patches by Dave Engberg and Konstantin Prei├čer
>    +1: markt, kkolinko
>    -1:
> -   kkolinko: minor tweaks:
> -     1) in Request.java in two places:
> -     s/new UnsupportedEncodingException()/new UnsupportedEncodingException(enc)/
> -     BTW, I see that this change to Request#setCharacterEncoding() has not been
> -     applied to TC7 yet.
> -     2) in B2CConverter we might s/ConcurrentHashMap/HashMap/ as the map is
> -     immutable at runtime. Though that is not of much difference.
> -

Konstantin, I left your vote in place as the changes are essentially
addressing your review comments but the comments did prompt a couple of
related changes so you may want to look at this again.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message