tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: Overhauling setclasspath.(bat|sh)?
Date Thu, 23 Jun 2011 14:37:43 GMT
Hi Chris,

On 23.06.2011 16:29, Christopher Schultz wrote:
> Rainer,
> 
> On 6/23/2011 7:33 AM, Rainer Jung wrote:
>> On 21.06.2011 11:40, Konstantin Kolinko wrote:
>>> 2011/6/20 Rainer Jung <rainer.jung@kippdata.de>:
>>>> 1) Renaming
>>>>
>>>> Since quite some time now the setclasspath script doesn't have anything
>>>> to do with setting a class path. It only searches for JRE / JDK and sets
>>>> up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS.
>>>>
>>>> So it would be more correct to call it checkjava.sh or setupjava.sh or
>>>> whatever.
>>>>
>>>> Do you think it's too late for TC 7 to rename the script?
>>>>
>>>> Good ideas for a new name?
>>>>
>>>
>>> The name may be mentioned in mailing list archives or elsewhere.
>>> I do not think it is worth renaming, but won't oppose it.
>>
>> Since at least Leon reported back he took the name as a suggestion to
>> include classpath customization in there and I can imagine there are
>> others as well for whom we would break their installation when
>> upgrading, I suggest we postpone renaming to TC 8. That might be the
>> time for a bigger script refactoring using shell and bat functions to
>> keep the catalina and tool-wrapper scripts in sync more easily.
> 
> It seems reasonable to allow for both setupjava.sh (or whatever the
> preferred name is) AND setclasspath.sh and prefer the former: if it
> exists, run that instead of setclasspath.sh. Also, we could issue a WARN
> message to the console if setclasspath.sh exists yet still run it.

We could, but the scripts are already pretty long and complex for simple
start scripts. I hesitate making them even harder to understand. I think
it's not worth the benefit for TC 7.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message