tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: Overhauling setclasspath.(bat|sh)?
Date Thu, 23 Jun 2011 11:33:11 GMT
On 21.06.2011 11:40, Konstantin Kolinko wrote:
> 2011/6/20 Rainer Jung <rainer.jung@kippdata.de>:
>> 1) Renaming
>>
>> Since quite some time now the setclasspath script doesn't have anything
>> to do with setting a class path. It only searches for JRE / JDK and sets
>> up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS.
>>
>> So it would be more correct to call it checkjava.sh or setupjava.sh or
>> whatever.
>>
>> Do you think it's too late for TC 7 to rename the script?
>>
>> Good ideas for a new name?
>>
> 
> The name may be mentioned in mailing list archives or elsewhere.
> I do not think it is worth renaming, but won't oppose it.

Since at least Leon reported back he took the name as a suggestion to
include classpath customization in there and I can imagine there are
others as well for whom we would break their installation when
upgrading, I suggest we postpone renaming to TC 8. That might be the
time for a bigger script refactoring using shell and bat functions to
keep the catalina and tool-wrapper scripts in sync more easily.

>> 2) Removing BASEDIR
>>
>> In addition it contains a validity check for BASEDIR. This is bogus:
>> whereever setclasspath is sources, we directly before set BASEDIR to the
>> path from which we source setclasspath. In addition, apart from the
>> validity check, BASEDIR is never ever used.
> 
> It is used:
> set "JAVA_ENDORSED_DIRS=%BASEDIR%\endorsed"
> 
> but given that it always is equal to CATALINA_HOME I think it is OK to
> replace it with CATALINA_HOME.

Removed / repaced in r1138835.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message