tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Diagram for AsyncStateMachine.java
Date Sun, 19 Jun 2011 09:00:29 GMT
On 19/06/2011 01:15, Konstantin Kolinko wrote:
> Hi, all!
> 
> I have redrawn the state diagram for trunk's
> org/apache/coyote/AsyncStateMachine.java.

Why?

> It is here:
> http://people.apache.org/~kkolinko/patches/AsyncStateMachine.txt
> 
> It matches the current diagram that is included in
> AsyncStateMachine.java JavaDoc, @rev.1137246.
> I am not committing it yet.
> 
> Feel free to enjoy and comment.

I'm not against a re-draw.

- I like the use of \ and / on the corners
- I like that it is more compact
- I like the addition of new
- I don't like that there are more cross-overs (I'd prefer none but I
don't think that is possible)
- I don't like that STARTING is out of line with DISPATCHED and STARTED

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message