tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1131490 - in /tomcat/trunk/java/org/apache/coyote: AbstractProcessor.java ajp/AbstractAjpProcessor.java http11/AbstractHttp11Processor.java http11/Http11AprProcessor.java http11/Http11NioProcessor.java http11/Http11Processor.java
Date Sat, 04 Jun 2011 20:54:35 GMT
On 04/06/2011 21:41, markt@apache.org wrote:
> Author: markt
> Date: Sat Jun  4 20:41:39 2011
> New Revision: 1131490
> 
> URL: http://svn.apache.org/viewvc?rev=1131490&view=rev
> Log:
> Create an AbstractProcessor. Start to pull common code from AJP and HTTP processors to
this abstract class.

I have started this refactoring with SocketIO / web sockets in mind.
There are subtle (and not so subtle) differences between the connectors
that I would like to iron out to:
- provide more consistent behaviour between connectors
- allow more refactoring to reduce (currently almost) duplicate code

The async implementation had to be slightly different between the
connectors because of the differences. This increased the complexity of
the original implementation and the ongoing maintenance. As far as
possible I would like to avoid that for SocketIO, hence this upfront
refactoring.

This should simplify any future SocketIO work as well as reducing
(removing?) the need for endpoint specific variations. I want to avoid,
as far as possible, copy and pasting code across multiple connectors and
the tweaking it slightly for that end point.

How far I'll be able to get with this is TBD but there is enough
commonality there to make me think it is worth the attempt. I'm going to
do this, as far as possible, in lots of small commits so it is easy to
review, easy for me to do a bit when I have a spare 5 mins and easy for
other folks to join in.

Mark




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message