tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkoli...@apache.org
Subject svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt
Date Tue, 28 Jun 2011 00:08:55 GMT
Author: kkolinko
Date: Tue Jun 28 00:08:55 2011
New Revision: 1140383

URL: http://svn.apache.org/viewvc?rev=1140383&view=rev
Log:
veto

Modified:
    tomcat/tc5.5.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1140383&r1=1140382&r2=1140383&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Tue Jun 28 00:08:55 2011
@@ -88,7 +88,8 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1138950&view=rev
   http://svn.apache.org/viewvc?rev=1138953&view=rev
   +1: markt
-  -1:
+  -1: kkolinko: because of magling the '_' character, which will break existing
+   code - see my comment in STATUS file of TC 6.0.
 
 * Multiple improvements to the Windows Installer
   - https://issues.apache.org/bugzilla/show_bug.cgi?id=33262

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1140383&r1=1140382&r2=1140383&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jun 28 00:08:55 2011
@@ -169,7 +169,14 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1138950&view=rev
   http://svn.apache.org/viewvc?rev=1138953&view=rev
   +1: markt, schultz
-  -1:
+  -1: kkolinko: 1) It would be OK if it were mangling only reserved words
+    (where the tag wouldn't compile previously, so there were no regressions),
+    but JspUtils.makeJavaIdentifier() mangles '_' character, which will break
+    code that was previously working. E.g. <%=hello_world%>
+    2) Maybe it would be better to prefix the names with [_]jsp_ and use some
+    numbered suffix, to never collide with names that people may use in their
+    code.
+
 
 * Multiple improvements to the Windows Installer
   - https://issues.apache.org/bugzilla/show_bug.cgi?id=33262



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message