tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1100940 - in /tomcat/trunk: java/org/apache/catalina/valves/LocalStrings.properties java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml webapps/docs/config/valve.xml
Date Mon, 09 May 2011 12:48:16 GMT
2011/5/9  <markt@apache.org>:
> Author: markt
> Date: Mon May  9 10:09:44 2011
> New Revision: 1100940
>
> URL: http://svn.apache.org/viewvc?rev=1100940&view=rev
> Log:
> Add additional configuration options to the RemoteIpValve to control ports.
> These are required by my TCK test environment since I have multiple connectors (with
different ports) configured all using the one Valve.
> If this has the desired effect, I'll port the changes to the RemoteIpFilter.
>
> Modified:
>    tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
>    tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
>    tomcat/trunk/webapps/docs/changelog.xml
>    tomcat/trunk/webapps/docs/config/valve.xml
>

> --- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties (original)
> +++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties Mon May  9
10:09:44 2011
> @@ -40,6 +40,7 @@ errorReportValve.rootCauseInLogs=The ful
>
>  # Remote IP valve
>  remoteIpValve.syntax=Invalid regular expressions [{0}] provided.
> +remoteIpValve.invalidPortHeader=Invalid value [{0}] found for port in HTP header [{1}]

s/HTP/HTTP/


> +                } catch (NumberFormatException nfe) {
> +                    log.debug(sm.getString(
> +                            "remoteIpValve.invalidPortHeader",
> +                            portHeaderValue, portHeader), nfe);
> +                }

if (log.isDebugEnabled()){...}

> +        used by the client to connect to the proxy. If not specified, the
> +        default of <code>null</code> is used.</p>

Maybe treat an empty string as if it were he null.


Is all this intended for HTTP/1.0 or 0.9 requests?
(HTTP/1.1 ones should have Host: header)

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message