tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1103633 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java
Date Mon, 16 May 2011 22:46:08 GMT
On 16/05/2011 22:54, Mark Thomas wrote:
> On 16/05/2011 22:47, Filip Hanik - Dev Lists wrote:
>> I take back my -1
>> looking at the javadoc, it defines -1 as infinite.
>>
>> So your commit is correct, but requires an addition
>>
>> -att.awaitReadLatch(readTimeout,TimeUnit.MILLISECONDS);
>>
>> +if (readTimeout<0) {
>> +  att.awaitReadLatch(Long.MAX_VALUE,TimeUnit.MILLISECONDS);
>> +} else {
>> +  att.awaitReadLatch(readTimeout,TimeUnit.MILLISECONDS);
>> +}
> 
> Thanks - I'll get that committed shortly.

Woot. That seems to have fixed a bunch of additional issues I was
seeing. Thanks again.

I'll test this more thoroughly tomorrow.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message