Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com
 designates 209.85.220.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=or3psGIA8lHThrjKSARwABYzL/KNQByucsXS+o1eoXvy99pQ6MDUho1r4rm+9v+Jf+
         PZ2RSm0OZeTdA7MJhB0cK1yKiAjzrZLxSCbtfQNPL7lWIw1kdzb667mXYh9/zfwBzSah
         wnU/7RG+4D530v5hN45AiMrMKfkJ9V49CjtmQ=
MIME-Version: 1.0
In-Reply-To: <20110410103330.F054C23889D5@eris.apache.org>
References: <20110410103330.F054C23889D5@eris.apache.org>
Date: Sun, 10 Apr 2011 19:06:16 +0400
Message-ID: <BANLkTimGyfrn_Lo0L3dvdppjU28itCumFA@mail.gmail.com>
Subject: Re: svn commit: r1090763 - in /tomcat/trunk:
 java/org/apache/jasper/compiler/DefaultErrorHandler.java
 webapps/docs/changelog.xml
From: Konstantin Kolinko <knst.kolinko@gmail.com>
To: Tomcat Developers List <dev@tomcat.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2011/4/10  <markt@apache.org>:
> Author: markt
> Date: Sun Apr 10 10:33:30 2011
> New Revision: 1090763
>
> URL: http://svn.apache.org/viewvc?rev=3D1090763&view=3Drev
> Log:
> Improve error reporting by labeling line/column numbers

This contradicts with i18n of errMsg.

If you are making this more human-readable, maybe add a whitespace
before "(" in "(line"


>
> Modified:
> =A0 =A0tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.j=
ava
> =A0 =A0tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandle=
r.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/com=
piler/DefaultErrorHandler.java?rev=3D1090763&r1=3D1090762&r2=3D1090763&view=
=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.java=
 (original)
> +++ tomcat/trunk/java/org/apache/jasper/compiler/DefaultErrorHandler.java=
 Sun Apr 10 10:33:30 2011
> @@ -38,8 +38,8 @@ class DefaultErrorHandler implements Err
> =A0 =A0 @Override
> =A0 =A0 public void jspError(String fname, int line, int column, String e=
rrMsg,
> =A0 =A0 =A0 =A0 =A0 =A0 Exception ex) throws JasperException {
> - =A0 =A0 =A0 =A0throw new JasperException(fname + "(" + line + "," + col=
umn + ")"
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0+ " " + errMsg, ex);
> + =A0 =A0 =A0 =A0throw new JasperException(fname + "(line: " + line + ", =
column: " +
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0column + ")" + " " + errMsg, ex);
> =A0 =A0 }
>
> =A0 =A0 /*
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml=
?rev=3D1090763&r1=3D1090762&r2=3D1090763&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Sun Apr 10 10:33:30 2011
> @@ -57,9 +57,9 @@
> =A0 =A0 =A0 =A0 separated by commas. (kkolinko)
> =A0 =A0 =A0 </update>
> =A0 =A0 =A0 <add>
> - =A0 =A0 =A0 =A0<bug>50306</bug>: New StuckThreadDetectionValve to detec=
t requests that take a
> - =A0 =A0 =A0 =A0long time to process, which might indicate that their pr=
ocessing threads are
> - =A0 =A0 =A0 =A0stuck. Based on a patch provided by TomLu. (slaurent)
> + =A0 =A0 =A0 =A0<bug>50306</bug>: New StuckThreadDetectionValve to detec=
t requests that
> + =A0 =A0 =A0 =A0take a long time to process, which might indicate that t=
heir processing
> + =A0 =A0 =A0 =A0threads are stuck. Based on a patch provided by TomLu. (=
slaurent)
> =A0 =A0 =A0 </add>
> =A0 =A0 </changelog>
> =A0 </subsection>
> @@ -71,6 +71,14 @@
> =A0 =A0 =A0 </fix>
> =A0 =A0 </changelog>
> =A0 </subsection>
> + =A0<subsection name=3D"Jasper">
> + =A0 =A0<changelog>
> + =A0 =A0 =A0<add>
> + =A0 =A0 =A0 =A0Label JSP/tag file line and column numbers when reportin=
g errors since
> + =A0 =A0 =A0 =A0it may not be immediately obvious what the numbers repre=
sent. (markt)
> + =A0 =A0 =A0</add>
> + =A0 =A0</changelog>
> + =A0</subsection>
> =A0 <subsection name=3D"Web applications">
> =A0 =A0 <changelog>
> =A0 =A0 =A0 <update>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org