tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: [VOTE] Release Apache Tomcat 7.0.12
Date Sun, 03 Apr 2011 17:14:21 GMT
On 01.04.2011 20:09, Mark Thomas wrote:
> The proposed Apache Tomcat 7.0.12 release is now available for voting.
>
> It can be obtained from:
> http://people.apache.org/~markt/dev/tomcat-7/v7.0.12/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_12/
>
> The proposed 7.0.12 release is:
>
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 7.0.12 Alpha
> [ ] Beta   - go ahead and release as 7.0.12 Beta
> [X] Stable - go ahead and release as 7.0.12 Stable
>
> Cheers,
>
> Mark


- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- only one Javadoc error, already fixe in trunk
- Unit tests run OK for BIO, NIO and APR (0ne failure for APR)
   using Java 1.6.0_24 (yes, all of them)

Concerning the APR failure:

INFO: Failures in 
output/build/logs/TEST-org.apache.tomcat.util.net.TestXxxEndpoint.APR.txt
WARN: Test failure in 
'output/build/logs/TEST-org.apache.tomcat.util.net.TestXxxEndpoint.APR.txt':
Testsuite: org.apache.tomcat.util.net.TestXxxEndpoint
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 9.327 sec

Failure only happens with APR (but only tried once).

Detailed Result is:

Testcase: testStartStopBindOnInit took 6.235 sec
         FAILED
null
junit.framework.AssertionFailedError
         at 
org.apache.tomcat.util.net.TestXxxEndpoint.testStartStopBindOnInit(TestXxxEndpoint.java:57)

Testcase: testStartStopBindOnStart took 3.08 sec


Additional log output:

Apr 3, 2011 5:00:48 PM org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.20.
Apr 3, 2011 5:00:48 PM org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters 
[false], random [true].
Apr 3, 2011 5:00:51 PM org.apache.coyote.AbstractProtocolHandler init
INFO: Initializing ProtocolHandler ["http-apr-8001"]
Apr 3, 2011 5:00:51 PM org.apache.catalina.core.StandardService 
startInternal
INFO: Starting service Tomcat
Apr 3, 2011 5:00:51 PM org.apache.catalina.core.StandardEngine startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.12
Apr 3, 2011 5:00:51 PM org.apache.catalina.startup.ContextConfig webConfig
INFO: No global web.xml found
Apr 3, 2011 5:00:53 PM org.apache.catalina.core.ApplicationContext log
INFO: ContextListener: contextInitialized()
Apr 3, 2011 5:00:53 PM org.apache.catalina.core.ApplicationContext log
INFO: SessionListener: contextInitialized()
Apr 3, 2011 5:00:53 PM org.apache.catalina.util.SessionIdGenerator 
createSecureRandom
INFO: Creation of SecureRandom instance for session ID generation using 
[SHA1PRNG] took [146] milliseconds.
Apr 3, 2011 5:00:53 PM org.apache.coyote.AbstractProtocolHandler start
INFO: Starting ProtocolHandler ["http-apr-8001"]
Apr 3, 2011 5:00:53 PM org.apache.coyote.AbstractProtocolHandler stop
INFO: Stopping ProtocolHandler ["http-apr-8001"]
Apr 3, 2011 5:00:54 PM org.apache.coyote.AbstractProtocolHandler pause
INFO: Pausing ProtocolHandler ["http-apr-8001"]
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.StandardService stopInternal
INFO: Stopping service Tomcat
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.ApplicationContext log
INFO: SessionListener: contextDestroyed()
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.ApplicationContext log
INFO: ContextListener: contextDestroyed()
Apr 3, 2011 5:00:54 PM org.apache.coyote.AbstractProtocolHandler destroy
INFO: Destroying ProtocolHandler ["http-apr-8001"]
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.20.
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters 
[false], random [true].
Apr 3, 2011 5:00:54 PM org.apache.coyote.AbstractProtocolHandler init
INFO: Initializing ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.StandardService 
startInternal
INFO: Starting service Tomcat
Apr 3, 2011 5:00:54 PM org.apache.catalina.core.StandardEngine startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.12
Apr 3, 2011 5:00:54 PM org.apache.catalina.startup.ContextConfig webConfig
INFO: No global web.xml found
Apr 3, 2011 5:00:55 PM org.apache.catalina.core.ApplicationContext log
INFO: ContextListener: contextInitialized()
Apr 3, 2011 5:00:55 PM org.apache.catalina.core.ApplicationContext log
INFO: SessionListener: contextInitialized()
Apr 3, 2011 5:00:55 PM org.apache.coyote.AbstractProtocolHandler start
INFO: Starting ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:55 PM org.apache.coyote.AbstractProtocolHandler stop
INFO: Stopping ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:56 PM org.apache.coyote.AbstractProtocolHandler start
INFO: Starting ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:56 PM org.apache.coyote.AbstractProtocolHandler pause
INFO: Pausing ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:57 PM org.apache.catalina.core.StandardService stopInternal
INFO: Stopping service Tomcat
Apr 3, 2011 5:00:57 PM org.apache.catalina.core.ApplicationContext log
INFO: SessionListener: contextDestroyed()
Apr 3, 2011 5:00:57 PM org.apache.catalina.core.ApplicationContext log
INFO: ContextListener: contextDestroyed()
Apr 3, 2011 5:00:57 PM org.apache.coyote.AbstractProtocolHandler stop
INFO: Stopping ProtocolHandler ["http-apr-8002"]
Apr 3, 2011 5:00:57 PM org.apache.coyote.AbstractProtocolHandler destroy
INFO: Destroying ProtocolHandler ["http-apr-8002"]

I did some debugging. It seems when using APR the connector binds to 
IPV6 and the Java based ServerSocket used to test whether the port is 
still taken binds to IPV4 - at least on my Solaris 10 Sparc System.

So indeed both can bind at the same time, even when I do not stop the 
connector at all.

To make the test valid I guess it had to bind to the socket using the 
same API as the connector (e.g. using the APR libs in the APR test 
case). If I try that, e.g. copying Socket setup from APREndpoint to the 
test class instead of using plain Java ServerSocket and bind to "::", 
then the test passes. Again, binding using the APRcode to 0.0.0.0 the 
test fails, i.e. binding suceeds.

The test works for the other two connectors and I could also verify that 
there was still a liste in netstat after stopping the connector in the 
case where an additional bind should have thrown an exception. So 
behaviour of the new config attribute bindOnInit seems OK.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message