tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51028] Build fails if Saxon 9 is on Ant's classpath
Date Wed, 06 Apr 2011 13:57:31 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51028

--- Comment #7 from Michael Osipov <1983-01-06@gmx.net> 2011-04-06 09:57:27 EDT ---
(In reply to comment #6)
> The relevant part of the log file says:
> 
>      [xslt] Processing E:\Projekte\tomcat-trunk\webapps\docs\changelog.xml to
> E:\Projekte\tomcat-trunk\output\build\webapps\docs\changelog.html
>      [xslt] E:\Projekte\tomcat-trunk\webapps\docs\tomcat-docs.xsl:470: Fatal
> Error! Illegal HTML character: decimal 150
> 
> Line 470 of tomcat-docs.xsl is
> 
>   <xsl:template match="changelog/fix">
>     <tr>
>       <xsl:variable name="src"><xsl:value-of
> select="$relative-path"/>/images/fix.gif</xsl:variable>
>       <td><img alt="fix" class="icon" src="{$src}"/></td>
>       <td><xsl:apply-templates/></td> <!-- 470 -->
>     </tr>
>   </xsl:template>
> 
> The character 150 is clearly not present in the XSL file.
> The Saxon error message is somewhat misleading, as the invalid character seems
> to be in changelog.xml at line 1488:
> 
>         <bug>49428</bug>: Re-implement the fix for bug <bug>49428</bug>
&#150;
> 
> Perhaps you can try temporarily editting that out, and see if that makes Saxon
> happy.

Sebb,

I removed the suspicious ref and it worked. I started digging and realized that
the document is really broken. In contrast to the built-in Xalan Saxon is not
lenient and strictly follows the specs.
The change was made by Konstantin, he doesn't seem to be encoding-savvy. If you
check the changelog.xml's encoding, you'll see UTF-8 is set in the XML prolog.
The entity ref '&#150;' (0x96, char 'en dash')
(http://en.wikipedia.org/wiki/Dash#Common_dashes) does only exist in Windows
1252 (http://en.wikipedia.org/wiki/Windows-1252#Codepage_layout) but translated
to Unicode, this is a contol char which is forbidden in XML.
To make this work, you have to reference a valid Unicode char. In this case it
would be '&#8211;' (U+2013) see
http://www.utf8-zeichentabelle.de/unicode-utf8-table.pl?start=8192

I changed that and 'ant release' ran perfectly. I guess this is a really simple
fix in SVN and the build should work on both XSLT processors.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message