Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <4D54172F.8000302@hanik.com>
Date: Thu, 10 Feb 2011 09:49:51 -0700
From: Filip Hanik - Dev Lists <devlists@hanik.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
 rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r1068989 -
 /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
References: <20110209173925.00A6623888FE@eris.apache.org>
 <AANLkTi=8YhyBdVz1FX-gwwVmWzSFxXUuAWhX=YYgmjeO@mail.gmail.com>
In-Reply-To: <AANLkTi=8YhyBdVz1FX-gwwVmWzSFxXUuAWhX=YYgmjeO@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

I will fix it. Reattempt is managed in the channel itself at a much lower level. That has always been the case. Adding reattempt here is 
ambiguous, so I will readjust the interface to return void.

best
Filip

On 2/10/2011 3:36 AM, Konstantin Kolinko wrote:
> 2011/2/9<fhanik@apache.org>:
>> Author: fhanik
>> Date: Wed Feb  9 17:39:24 2011
>> New Revision: 1068989
>>
>> URL: http://svn.apache.org/viewvc?rev=1068989&view=rev
>> Log:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=50667
>> Move the callback outside try/catch to avoid duplicate callbacks
>>
> I do not quite get it.
>
> JavaDoc comment for ExtendedRpcCallback#replyFailed(..) says
>   @return true if the callback would like to reattempt the reply, false otherwise
>
> In this code returning true will result in falling through and just a
> duplicate call to the handler, now reporting success:
> excallback.replySucceeded(rmsg.message, reply, sender);
>
> I do not see any "reattempt" here.
>
> Best regards,
> Konstantin Kolinko
>
>> Modified:
>>     tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
>> Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1068989&r1=1068988&r2=1068989&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original)
>> +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Wed Feb  9 17:39:24 2011
>> @@ -158,9 +158,6 @@ public class RpcChannel implements Chann
>>                          channel.send(new Member[] {sender}, rmsg,replyMessageOptions&  ~Channel.SEND_OPTIONS_SYNCHRONIZED_ACK);
>>                      }
>>                      finished = true;
>> -                    if (excallback != null&&  !asyncReply) {
>> -                        excallback.replySucceeded(rmsg.message, reply, sender);
>> -                    }
>>                  }catch ( Exception x )  {
>>                      if (excallback != null&&  !asyncReply) {
>>                          finished = !excallback.replyFailed(rmsg.message, reply, sender, x);
>> @@ -169,6 +166,9 @@ public class RpcChannel implements Chann
>>                          log.error("Unable to send back reply in RpcChannel.",x);
>>                      }
>>                  }
>> +                if (finished&&  excallback != null&&  !asyncReply) {
>> +                    excallback.replySucceeded(rmsg.message, reply, sender);
>> +                }
>>              }
>>          }//end if
>>      }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1204 / Virus Database: 1435/3434 - Release Date: 02/10/11
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org