tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r1068808 - /tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
Date Wed, 09 Feb 2011 17:47:53 GMT
I'm glad you commented, there should be no looping at all. It was a left over from a previous
proposal
fixed in r1068996

Filip

On 2/9/2011 2:35 AM, kkolinko@apache.org wrote:
> Author: kkolinko
> Date: Wed Feb  9 09:35:16 2011
> New Revision: 1068808
>
> URL: http://svn.apache.org/viewvc?rev=1068808&view=rev
> Log:
> Followup to r1068549 - add annotations.
>
> I thought about moving ErrorHandler instance creation outside the retry loop, but actually
that is not needed: looping happens only when asyncReply==false and ErrorHandler is created
only when asyncReply==true. Thus it is created only once.
>
> Modified:
>      tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java?rev=1068808&r1=1068807&r2=1068808&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java Wed Feb  9 09:35:16
2011
> @@ -139,10 +139,11 @@ public class RpcChannel implements Chann
>                   final Member fsender = sender;
>                   if (excallback!=null&&  asyncReply) {
>                       handler = new ErrorHandler() {
> +                        @Override
>                           public void handleError(ChannelException x, UniqueId id) {
>                               excallback.replyFailed(request, response, fsender, x);
>                           }
> -
> +                        @Override
>                           public void handleCompletion(UniqueId id) {
>                               excallback.replySucceeded(request, response, fsender);
>                           }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1204 / Virus Database: 1435/3431 - Release Date: 02/08/11
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message