tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1067734 - /tomcat/trunk/java/org/apache/catalina/valves/CrawlerSessionManagerValve.java
Date Sun, 06 Feb 2011 20:54:55 GMT
On 06/02/2011 20:45, Konstantin Kolinko wrote:
> Wrong.
> 1) Pattern is threadsafe, but Matcher is not.
I'll fix that.

> 2) If set*() method in not called, uaMatcher is not initialized and
> remains null by default.
Handled by the initInternal() method.

> BTW, are these bots using several user-agent headers?  Maybe do not
> enable the valve if there are multiple headers?
Not that I have seen. That should save a few cycles.

Still trying to figure out why it doesn't work with Jira at the moment.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message