tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call
Date Wed, 09 Feb 2011 17:40:21 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50667

--- Comment #13 from Filip Hanik <fhanik@apache.org> 2011-02-09 12:40:16 EST ---
(In reply to comment #12)
> Hi Filip,
> 
> I would have thought the second callback could be implemented in the same class
> is the (Extended)RpcCallback, but at any rate it's your call.

It is, the other patch introduced a third class for callbacks that was wrapped
in an error handler. 

 I got what I
> wanted out of this, so it's fine by me.

cool

also, the retry functionality has been removed, as it can be configured as an
interceptor, or configured further down in the stack.

> 
> A few remarks on the code:
> 1. Unless I'm very much mistaken, the retry functionality won't work in async
> mode. This should be documented in ExtendedRpcCallback#replyFailed.

It should work in async mode, since it passes the EXRPC object into the channel
as a feedback object wrapped in an error handler.


> 3. The call to ExtendedRpcCallback#replySucceeded in the synchronous case
> should be move outside the try/catch block. Perhaps put it in a try/catch of
> its own. The way it is now, it would cause spurious behaviour if it were to
> throw a RuntimeException.

yes, for sure, fixed in r1068989


thanks for your feedback
Filip

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message