tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 50667] Tribes | RpcChannel | Add a callback for cases when an error occured sending a reply to an RP call
Date Wed, 09 Feb 2011 09:59:42 GMT

--- Comment #12 from Olivier Costet <> 2011-02-09 04:59:37 EST ---
Hi Filip,

I would have thought the second callback could be implemented in the same class
is the (Extended)RpcCallback, but at any rate it's your call. I got what I
wanted out of this, so it's fine by me.

A few remarks on the code:
1. Unless I'm very much mistaken, the retry functionality won't work in async
mode. This should be documented in ExtendedRpcCallback#replyFailed.
2. As far as I can see, GroupChannel#send does handle the case where the
ErrorHandler is null, so you probably don't need an if/else to call the
appropriate Channel#send in RpcChannel#messageReceived. Actually, this would
depend on the contract of Channel#send, which I'm not aware of, so I don't know
for sure.
3. The call to ExtendedRpcCallback#replySucceeded in the synchronous case
should be move outside the try/catch block. Perhaps put it in a try/catch of
its own. The way it is now, it would cause spurious behaviour if it were to
throw a RuntimeException.

I think that's about it.


Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message