tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1067039 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java
Date Thu, 03 Feb 2011 23:56:55 GMT
Author: markt
Date: Thu Feb  3 23:56:55 2011
New Revision: 1067039

URL: http://svn.apache.org/viewvc?rev=1067039&view=rev
Log:
Reduce severity level. The ASF Jira instance logs were filling with these

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java?rev=1067039&r1=1067038&r2=1067039&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java Thu Feb  3 23:56:55 2011
@@ -249,21 +249,23 @@ public final class Parameters {
             pos=valEnd+1;
             
             if( nameEnd<=nameStart ) {
-                StringBuilder msg = new StringBuilder("Parameters: Invalid chunk ");
-                // No name eg ...&=xx&... will trigger this
-                if (valEnd >= nameStart) {
-                    msg.append('\'');
-                    try {
-                        msg.append(new String(bytes, nameStart,
-                                valEnd - nameStart, DEFAULT_ENCODING));
-                    } catch (UnsupportedEncodingException e) {
-                        // Should never happen...
-                        log.error("Unable to convert bytes", e);
+                if (log.isInfoEnabled()) {
+                    StringBuilder msg = new StringBuilder("Parameters: Invalid chunk ");
+                    // No name eg ...&=xx&... will trigger this
+                    if (valEnd >= nameStart) {
+                        msg.append('\'');
+                        try {
+                            msg.append(new String(bytes, nameStart,
+                                    valEnd - nameStart, DEFAULT_ENCODING));
+                        } catch (UnsupportedEncodingException e) {
+                            // Should never happen...
+                            log.error("Unable to convert bytes", e);
+                        }
+                        msg.append("' ");
                     }
-                    msg.append("' ");
+                    msg.append("ignored.");
+                    log.info(msg);
                 }
-                msg.append("ignored.");
-                log.warn(msg);
                 continue;
                 // invalid chunk - it's better to ignore
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message