tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [PROPOSAL] Remove o.a.catlina.InstanceListener
Date Fri, 07 Jan 2011 12:21:24 GMT
On 07/01/2011 12:18, Konstantin Kolinko wrote:
> 2011/1/7 Mark Thomas <markt@apache.org>:
>> All,
>>
>> I just stumbled across o.a.catlina.InstanceListener and the associated
>> classes when I was reviewing the results of the unused code detector.
>>
>> It isn't used at all in 7.0.x, nor can I find any sign of it being used
>> in 6.0.x and 5.5.x. A search of the mail archives doesn't turn up any
>> uses either. On that basis, I intend to remove it before I tag 7.0.6.
>> Any objections?
> 
> We indeed do not have our own classes that implement InstanceListener,
> but if you search for o.a.c.InstanceEvent, it is used in a plenty of places
> (to implement this feature actually).
> 
> So it is not just throwing away classes, it also removal of many lines of code.

Yep - the main reason I wanted to get rid of it.

> Searching the web, it is mentioned e.g. here:
> http://community.jboss.org/message/288150?tstart=0
> 
> See also
> http://anonsvn.jboss.org/repos/jbossas/tags/JBoss_5_1_0_GA/tomcat/src/main/org/jboss/web/tomcat/security/RunAsListener.java
> 
> My opinion on this proposal is "-1".

Drat. If it is being used as an integration point then I guess we'll
have to keep it. Oh well.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message