tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 50410] Poll.create with THREADSAFE will silently switch the flag off
Date Fri, 07 Jan 2011 11:10:52 GMT

Mladen Turk <> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #1 from Mladen Turk <> 2011-01-07 06:10:48 EST ---
This is APR's wrongly designed API.
No mater if the native OS pollset implementation is thread safe
or not, if APR_POLLSET_THREADSAFE is not provided internal
mutex will be created. However if required create will fail
and we would need to call that API again.
If not required beside creating unneeded mutex what's worse
it's be used although not required, so it's clear why
we wish too call it with that flag.

However from the end user (tomcat native) point of view
this makes no difference at all.
What we do internally is to clear that flag and try again
without that flag, fixing the APR api which should
treat APR_POLLSET_THREADSAFE as a 'hint' not as a requirement.

Whether native pollset implementation is thread safe or not
makes no real value because if it's not APR will create
internal mutex protecting it, so this is just one
of those "legacy" api's.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message