tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49953] Missing @Override annotations
Date Fri, 07 Jan 2011 01:06:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49953

Sebb <sebb@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|LATER                       |

--- Comment #5 from Sebb <sebb@apache.org> 2011-01-06 20:06:49 EST ---
(In reply to comment #4)
> Not true
> 
> public interface Itest {
>  public void foo();
> }
> 
> public class test implements Itest {
>  @Override
>  public void foo() {
>  }
> }
> 
> will not compile in Java 5

Exactly, overrides of interface methods require Java 1.6.
This is the case for many of the existing @Overrides in DataSourceProxy,
PoolProperties and ConnectionPool and others, which is one of the reasons jdbc
pool won't compile currently with Java 5.

Does this mean that those @Overrides should be removed?

However, AFAICT the patch only adds overrides for methods which override
superclass methods, so will compile with Java 1.5.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message