tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: [PROPOSAL] Remove o.a.catlina.InstanceListener
Date Fri, 07 Jan 2011 12:32:53 GMT
On Fri, 2011-01-07 at 15:18 +0300, Konstantin Kolinko wrote:
> We indeed do not have our own classes that implement InstanceListener,
> but if you search for o.a.c.InstanceEvent, it is used in a plenty of places
> (to implement this feature actually).
> 
> So it is not just throwing away classes, it also removal of many lines of code.
> 
> Searching the web, it is mentioned e.g. here:
> http://community.jboss.org/message/288150?tstart=0
> 
> See also
> http://anonsvn.jboss.org/repos/jbossas/tags/JBoss_5_1_0_GA/tomcat/src/main/org/jboss/web/tomcat/security/RunAsListener.java
> 
> My opinion on this proposal is "-1".

The web container that is used there is not fully compatible with Tomcat
already, so you can remove InstanceListener in Tomcat without breaking
AS.

However, unless there's a comparable hook somewhere, removing this is
probably not a good idea, valves and filters are not exactly the same
thing.

Rémy



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message