Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 40523 invoked from network); 7 Dec 2010 22:22:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 7 Dec 2010 22:22:38 -0000 Received: (qmail 84300 invoked by uid 500); 7 Dec 2010 22:22:37 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 84237 invoked by uid 500); 7 Dec 2010 22:22:37 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 84228 invoked by uid 99); 7 Dec 2010 22:22:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Dec 2010 22:22:37 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sylvain.laurent@gmail.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-ww0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Dec 2010 22:22:28 +0000 Received: by wwi17 with SMTP id 17so439885wwi.0 for ; Tue, 07 Dec 2010 14:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:content-type :mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer; bh=rBQ8sbH9A8deGpksyrFskniAL+XyWJxxwquy7lRT/9w=; b=SMqNLL6nCXvwGAjVBh3yXqT3jtWfKm74/kzVT7Cja81t4h6HObqOkUYS0qvIbzwmlR BPd+4R4MAkjWgEpMKi/7R3E3GsLW5qPr8HdeCZh2EHY6X2ljAuetU4tlvBqVlL0KmC+3 K4VTCnr4ViyLs1THtiSevJkFTok0azv2kp/lo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer; b=lUhiNl0yPlMR0JoOuSXPgXB5Bnp4SLFnrHzM1BU0X69l57Vyy1FTTCfT6gFQ19tgij ivbpXjvGU9NEnqAPbx18X51uN+CHKMICgwg70cQHTphvR7/uwngzBo7GXyP6pFEJWZfx Z/cPNvjw1LI8i51uC1G7QOs80o9DL94tN820w= Received: by 10.227.11.198 with SMTP id u6mr8104756wbu.111.1291760528197; Tue, 07 Dec 2010 14:22:08 -0800 (PST) Received: from [10.0.0.3] (84-74-30-24.dclient.hispeed.ch [84.74.30.24]) by mx.google.com with ESMTPS id x3sm3222327wes.46.2010.12.07.14.22.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 07 Dec 2010 14:22:06 -0800 (PST) Sender: Sylvain Laurent Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Apple Message framework v1082) Subject: Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/ From: Sylvain Laurent In-Reply-To: <4CFE6246.9090901@apache.org> Date: Tue, 7 Dec 2010 23:22:04 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <6E32C86F-969A-40AE-861B-D7391BDEAEE9@m4x.org> References: <20101206204915.76849238897A@eris.apache.org> <4CFD53FB.6050208@apache.org> <1291724976.3873.31.camel@cat> <4CFE3678.3060804@apache.org> <4CFE6246.9090901@apache.org> To: "Tomcat Developers List" X-Mailer: Apple Mail (2.1082) X-Virus-Checked: Checked by ClamAV on apache.org On 7 d=E9c. 2010, at 17:35, Mark Thomas wrote: > +1. Line length is an area I am becoming increasingly happy to be > flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the = code > more readable then I'd be fine with it. As a rookie, I did not want to start bothering you with this, but since = you bring the topic... I think 80 is somewhat outdated: screens are now bigger, and especially = wider (16:9 vs 4:3). I think we should allow a greater line length to reduce the code height = (the number of lines). My preference is 100 characters per line. Sylvain= --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org