Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: domain of sylvain.laurent@gmail.com
 designates 74.125.82.41 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:content-type:mime-version:subject:from:in-reply-to:date
         :content-transfer-encoding:message-id:references:to:x-mailer;
        b=Qun5mTaSOHUvvuzNAcjOGO8Wd3xZ8hmHiyZgLx7GxoImrgOsF1aBvakF05RZijhTy7
         JwGdVKDoWzY5mMzYXo1Naq8Zpazp/7cefVCOvjU48RGVySSraDKlugN3+eEOyvP4ghi8
         buaenQMZWToxDnFWxEp54oEHfCvVpgI32t1LQ=
Sender: Sylvain Laurent <sylvain.laurent@gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1082)
Subject: Re: svn commit: r1044746 -
 /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
From: Sylvain Laurent <sylvain.laurent@m4x.org>
In-Reply-To: <4D0413B5.8050207@apache.org>
Date: Sun, 12 Dec 2010 01:17:32 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <558FF38E-38BB-471F-B360-B17F4F4429A7@m4x.org>
References: <20101212001040.33BA62388903@eris.apache.org>
 <4D0413B5.8050207@apache.org>
To: "Tomcat Developers List" <dev@tomcat.apache.org>

oops, I just forgot a dot and a new line... fixed in rev 1044747.

On 12 d=E9c. 2010, at 01:13, Mark Thomas wrote:

> On 12/12/2010 00:10, slaurent@apache.org wrote:
>> Author: slaurent
>> Date: Sun Dec 12 00:10:39 2010
>> New Revision: 1044746
>>=20
>> @@ -4862,10 +4862,10 @@ public class StandardContext extends Con
>>                 if ((loader !=3D null) && (loader instanceof =
Lifecycle))
>>                     ((Lifecycle) loader).start();
>>=20
>> -                // Unbinding thread
>> +                // since the loader just started, the webapp =
classloader is now
>> +                // created by calling unbindThread and bindThread in =
a row, we
>> +                // setup the current Thread CCL to be the webapp =
classloader
>>                 unbindThread(oldCCL);
>> -
>> -                // Binding thread
>>                 oldCCL =3D bindThread();
>=20
> That new comment doesn't look right. The class loader is not created =
by
> calling unbindThread and bindThread in a row.
>=20
> Mark
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org