Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 27813 invoked from network); 17 Dec 2010 16:07:13 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Dec 2010 16:07:13 -0000 Received: (qmail 62233 invoked by uid 500); 17 Dec 2010 16:07:13 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 61938 invoked by uid 500); 17 Dec 2010 16:07:12 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 61927 invoked by uid 99); 17 Dec 2010 16:07:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Dec 2010 16:07:11 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [76.96.62.48] (HELO qmta05.westchester.pa.mail.comcast.net) (76.96.62.48) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Dec 2010 16:07:11 +0000 Received: from omta01.westchester.pa.mail.comcast.net ([76.96.62.11]) by qmta05.westchester.pa.mail.comcast.net with comcast id kDlS1f00E0EZKEL55G6oAQ; Fri, 17 Dec 2010 16:06:51 +0000 Received: from [192.168.1.201] ([69.143.109.145]) by omta01.westchester.pa.mail.comcast.net with comcast id kG6f1f00i38FjT13MG6gMZ; Fri, 17 Dec 2010 16:06:40 +0000 Message-ID: <4D0B8A8F.3010404@christopherschultz.net> Date: Fri, 17 Dec 2010 11:06:39 -0500 From: Christopher Schultz User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: Getting Started Tomcat Development References: In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig17871E94B72CE07CAE76B816" --------------enig17871E94B72CE07CAE76B816 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Faisal, On 12/17/2010 8:35 AM, Faisal CM wrote: > How can > i make sure that patch meets the exact requirement as if enhancement > does not say much? Your patch should be as small as possible to fix the issue / enhancement.= > 2) - Can i get information/guideline of all the > steps needs to be done before submitting a patch through bugzilla > (e.g proposed patch, testcases etc)? Technically, you can submit anything you'd like. /Successful/ patches should: 0. Not contain any tab characters :) 1. Solve the problem in the bug 2. Include any appropriate documentation (new configuration, notes about behavior, etc.) 3. Include unit test cases if appropriate 4. Not include additional changes (code formatting, etc.) 5. Not break anything else :) Thanks for your contribution(s), -chris --------------enig17871E94B72CE07CAE76B816 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk0Lio8ACgkQ9CaO5/Lv0PCIowCeP+9rd0Kp+gTe5O9KMpziTczE dJoAoId+gF2QSLUaIYdQmLRv4iR+xIyU =SAQv -----END PGP SIGNATURE----- --------------enig17871E94B72CE07CAE76B816--