From dev-return-112286-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Wed Dec 08 16:10:05 2010 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 40534 invoked from network); 8 Dec 2010 16:10:04 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Dec 2010 16:10:04 -0000 Received: (qmail 93418 invoked by uid 500); 8 Dec 2010 16:10:04 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 93117 invoked by uid 500); 8 Dec 2010 16:10:03 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 93108 invoked by uid 99); 8 Dec 2010 16:10:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 16:10:03 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 08 Dec 2010 16:10:01 +0000 Received: (qmail 40229 invoked by uid 99); 8 Dec 2010 16:09:39 -0000 Received: from localhost.apache.org (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 16:09:39 +0000 Message-ID: <4CFFADBC.1030509@apache.org> Date: Wed, 08 Dec 2010 16:09:32 +0000 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/ References: <20101203160751.7996423889B1@eris.apache.org> <4CFBCC7C.50106@apache.org> <4CFFA6BF.2020100@christopherschultz.net> In-Reply-To: <4CFFA6BF.2020100@christopherschultz.net> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 08/12/2010 15:39, Christopher Schultz wrote: > Mark, > > On 12/5/2010 12:31 PM, Mark Thomas wrote: >> On 03/12/2010 16:07, schultz@apache.org wrote: >>> Author: schultz >>> Date: Fri Dec 3 16:07:50 2010 >>> New Revision: 1041892 >>> >>> URL: http://svn.apache.org/viewvc?rev=1041892&view=rev >>> Log: >>> Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT requests >> >> Some minor comments in-line. >> >>> + public boolean isParseBodyMethod(String method) >> This method could (should?) be protected rather then public. > > While fixing the other issues, I was thinking about a few things. Nearly > all methods in the Connector class are public, not protected. The > mutators are the only dangerous methods and they must be public so that > the Digester can set them during Connector configuration. > > Is there a compelling reason to make the isParseBodyMethod method > protected? Or, is that simply considered an implementation detail that > should be hidden from the public API? Just a general principal not to expose stuff to the public API that doesn't have to be. It is also easy to change protected to public later, harder to go the other way. One of the many things on my to-do list is to clean up the dependencies between the modules, only expose the stuff that needs to be exposed and expose everything through interfaces. Given the length of my to-do list and the rate I am making progress I suspect that will happen sometime around Tomcat 12 :) Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org