From dev-return-112220-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Mon Dec 06 21:22:38 2010 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 43087 invoked from network); 6 Dec 2010 21:22:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 6 Dec 2010 21:22:38 -0000 Received: (qmail 2037 invoked by uid 500); 6 Dec 2010 21:22:37 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 1980 invoked by uid 500); 6 Dec 2010 21:22:37 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 1971 invoked by uid 99); 6 Dec 2010 21:22:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Dec 2010 21:22:37 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 06 Dec 2010 21:22:34 +0000 Received: (qmail 42935 invoked by uid 99); 6 Dec 2010 21:22:13 -0000 Received: from localhost.apache.org (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Dec 2010 21:22:13 +0000 Message-ID: <4CFD53FB.6050208@apache.org> Date: Mon, 06 Dec 2010 21:22:03 +0000 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-GB; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/ References: <20101206204915.76849238897A@eris.apache.org> In-Reply-To: <20101206204915.76849238897A@eris.apache.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 06/12/2010 20:49, slaurent@apache.org wrote: > Author: slaurent > Date: Mon Dec 6 20:49:14 2010 > New Revision: 1042786 > > URL: http://svn.apache.org/viewvc?rev=1042786&view=rev > @@ -63,7 +72,7 @@ public class ThreadLocalLeakPreventionLi > try { > Lifecycle lifecycle = event.getLifecycle(); > if (Lifecycle.AFTER_START_EVENT.equals(event.getType()) > - && lifecycle instanceof Server) { > + && lifecycle instanceof Server) { > // when the server starts, we register ourself as listener for > // all context > // as well as container event listener so that we know when new That indenting is now misleading (it was fine before) and the operator is still at the beginning of the line. > - log.error("Exception processing event " + event, e); > + String msg = > + sm.getString( > + "threadLocalLeakPreventionListener.lifecycleEvent.error", > + event); > + log.error(msg, e); More auto formatting "helpfulness" by the look of it. No reason for String msg = sm.getString( not to be on one line. If we can pull some Eclipse settings together to help folks with this that would be great. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org