tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Date Tue, 07 Dec 2010 14:48:44 GMT
2010/12/7 Mark Thomas <markt@apache.org>:
>
> My preference is for operator before since I believe it aids readability.
> YMMV.
>
>> So is operator after line wrapping really a tomcat standard?
>
> operator before line wrapping is the direction the code is heading in and
> the direction I think it should continue to head.
>

My personal preference is that the new code formatting were more or
less consistent with the rest of the file. I *do not* care where
operator is on that line.

If it is readable, it is fine with me.  I see no value in bothering
about it besides some aesthetics.

(It makes no difference in Java. Though in Javascript placing operator
at the end of the line is preferred, because of implicit ';' that can
otherwise split the line in two).

Trying to enforce a style here goes nowhere: such changes cannot be
backported to TC6, and you cannot limit checkstyle to check only files
created after certain date.

2010/12/7 Caldarale, Charles R <Chuck.Caldarale@unisys.com>:
> Strongly agree.  I've been programming in a multitude of languages for over forty years,
and I find operator before line break to be a much more readable (and aesthetically pleasing)
arrangement.
>

If you have some "long string" that occupies all space up to position
79, forcing some operator after it to stay on the same line
effectively increases its length by several chars and will cause the
whole string to be placed on the new line. It just wastes space and
becomes ugly.



Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message