tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sylvain Laurent <sylvain.laur...@m4x.org>
Subject Re: svn commit: r1044746 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Date Sun, 12 Dec 2010 00:17:32 GMT
oops, I just forgot a dot and a new line... fixed in rev 1044747.

On 12 déc. 2010, at 01:13, Mark Thomas wrote:

> On 12/12/2010 00:10, slaurent@apache.org wrote:
>> Author: slaurent
>> Date: Sun Dec 12 00:10:39 2010
>> New Revision: 1044746
>> 
>> @@ -4862,10 +4862,10 @@ public class StandardContext extends Con
>>                 if ((loader != null) && (loader instanceof Lifecycle))
>>                     ((Lifecycle) loader).start();
>> 
>> -                // Unbinding thread
>> +                // since the loader just started, the webapp classloader is now
>> +                // created by calling unbindThread and bindThread in a row, we
>> +                // setup the current Thread CCL to be the webapp classloader
>>                 unbindThread(oldCCL);
>> -
>> -                // Binding thread
>>                 oldCCL = bindThread();
> 
> That new comment doesn't look right. The class loader is not created by
> calling unbindThread and bindThread in a row.
> 
> Mark
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message