tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: Tomcat 7 & regex
Date Sat, 25 Dec 2010 19:53:08 GMT
On 25/12/2010 01:49, Tim Funk wrote:
> +0.5 - I wonder if in some cases - it may be preferable to use a
> property called split which lets the user define the separator which we
> can pass to String.split(). [Which OTOH may be more confusing (yet
> powerful) since the user is using a regex to split get a list of regex]

I think that just makes it more complicated. There is no need to split
anything up since the regex can just use |. Rather than mix regex plus
our own proprietary splitting mechanism, I think we should just use the
support already provided by regex to do the same thing.

Mark

> 
> -Tim
> 
> On 12/24/2010 1:34 PM, Mark Thomas wrote:
>> There are a number of configuration properties defined as "comma
>> separated regular expressions". As someone pointed out at at ApacheCon
>> that is a little odd. It stops "," being used in an expression and is
>> inefficient.
>>
>> Having just been bitten by this while setting up the new Jira instance,
>> I intend change all properties that take regex in Tomcat 7 to use a
>> single regex. This will simplify the code, simplify configuration and
>> make the regex processing faster.
>>
>> I probably won't get around to actually doing this until the new year.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message