tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r1051539 - /tomcat/trunk/java/org/apache/tomcat/util/threads/CounterLatch.java
Date Wed, 22 Dec 2010 16:04:39 GMT
On 12/21/2010 7:29 PM, sebb wrote:
>
>> -    private long signal;
>> +    private volatile long signal;
> It would be cheaper to make it final as it's only ever set in the ctor
> and is immutable.
nothing cheaper, volatile are only expensive to write, not read. if maxConnections becomes
a dynamically adjustable attribute, so will this 
one have to be.
>>      private volatile boolean released = false;
>>
>>      /**
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1170 / Virus Database: 1435/3329 - Release Date: 12/21/10
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message