tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Getting Started Tomcat Development
Date Fri, 17 Dec 2010 16:06:39 GMT
Faisal,

On 12/17/2010 8:35 AM, Faisal CM wrote:
> How can
> i make sure that patch meets the exact requirement as if enhancement
> does not say much?

Your patch should be as small as possible to fix the issue / enhancement.

> 2) - Can i get information/guideline of all the
> steps needs to be done before submitting a patch through bugzilla
> (e.g proposed patch, testcases etc)?

Technically, you can submit anything you'd like. /Successful/ patches
should:

0. Not contain any tab characters :)
1. Solve the problem in the bug
2. Include any appropriate documentation (new configuration,
   notes about behavior, etc.)
3. Include unit test cases if appropriate
4. Not include additional changes (code formatting, etc.)
5. Not break anything else :)

Thanks for your contribution(s),
-chris


Mime
View raw message