tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Adding annotations to JspC
Date Fri, 17 Dec 2010 15:59:58 GMT
Konstantin,

On 12/17/2010 3:49 AM, Konstantin Kolinko wrote:
> 2010/12/16 Christopher Schultz <chris@christopherschultz.net>:
>> All,
>>
>> I'm looking at writing a patch for bug 50234 ("JspC use servlet 3.0
>> features": https://issues.apache.org/bugzilla/show_bug.cgi?id=50234) and
>> I'm thinking that the annotations should actually have nothing to do
>> with the precompiler, but the compiler itself.
>>
>> Can anyone think of a reason not to simply update
>> jasper.compiler.Generator to add the @WebServlet annotations? I believe
>> everything else needs to be handled by JspC.
>>
> 
> Note, that you still have to preserve compatibility for the webapps
> that adhere to Servlet 2.5 and earlier versions of specification.
> 
> Using JspC may be limited to Servlet 3.0+ ones (if it is worth it),
> but just deploying earlier versions of the webapps on Tomcat should
> still work.

I think that limiting the compiled servlets to Tomcat 7 (Servlet 3.0+)
is okay: the documentation states that JSPs should be recompiled using
the version of Tomcat you expect to use for deployment, so backward
compatibility isn't something I'm terribly concerned about.

> Do you really need @WebServlet here? Are the jsp servlets discovered
> though annotations, or do you list them in web-fragment.xml ?

The enhancement requests /both/ of those, actually: generating a formal
web-fragment.xml (the current implementation just dumps bare <servlet>
and <servlet-mapping> elements -- it's not currently a valid XML
document) as well as @WebServlet annotations on the classes. The idea is
that JspC could generate a JAR file that could be tossed-into a webapp
instead of having all those class files sitting around, and also having
to modify the webapp's web.xml file. With the annotations and/or a
WEB-INF/web-fragment.xml, the compiled JSPs could be detected and
configured automatically.

-chris


Mime
View raw message