tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1043444 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpMessage.java Constants.java
Date Wed, 08 Dec 2010 16:09:37 GMT
On 08/12/2010 15:52, Konstantin Kolinko wrote:
> 2010/12/8  <markt@apache.org>:
>> Author: markt
>> Date: Wed Dec  8 15:07:20 2010
>> New Revision: 1043444
>>
>> URL: http://svn.apache.org/viewvc?rev=1043444&view=rev
>> Log:
>> Remove some unused code
>> Fix some FindBugs niggles
>>
>> Modified:
>>    tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
>>    tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java
>>    tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
>>
>> Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java?rev=1043444&r1=1043443&r2=1043444&view=diff
>>
> 
> Why are you removing those methods from AjpMessage?
> That is an utility class that deals with AJP protocol, and those
> methods look not broken and useful.

Simply that the methods weren't being used and I don't see the point of
retaining and maintaining code that isn't being used.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message