tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
Date Wed, 08 Dec 2010 16:09:32 GMT
On 08/12/2010 15:39, Christopher Schultz wrote:
> Mark,
> 
> On 12/5/2010 12:31 PM, Mark Thomas wrote:
>> On 03/12/2010 16:07, schultz@apache.org wrote:
>>> Author: schultz
>>> Date: Fri Dec  3 16:07:50 2010
>>> New Revision: 1041892
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1041892&view=rev
>>> Log:
>>> Fixed bug 48692: Provide option to parse application/x-www-form-urlencoded PUT
requests
>>
>> Some minor comments in-line.
>>
>>> +    public boolean isParseBodyMethod(String method)
>> This method could (should?) be protected rather then public.
> 
> While fixing the other issues, I was thinking about a few things. Nearly
> all methods in the Connector class are public, not protected. The
> mutators are the only dangerous methods and they must be public so that
> the Digester can set them during Connector configuration.
> 
> Is there a compelling reason to make the isParseBodyMethod method
> protected? Or, is that simply considered an implementation detail that
> should be hidden from the public API?

Just a general principal not to expose stuff to the public API that
doesn't have to be. It is also easy to change protected to public later,
harder to go the other way.

One of the many things on my to-do list is to clean up the dependencies
between the modules, only expose the stuff that needs to be exposed and
expose everything through interfaces. Given the length of my to-do list
and the rate I am making progress I suspect that will happen sometime
around Tomcat 12 :)

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message