tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Date Tue, 07 Dec 2010 16:35:18 GMT
On 07/12/2010 14:48, Konstantin Kolinko wrote:
> 2010/12/7 Mark Thomas <markt@apache.org>:
>>
>> My preference is for operator before since I believe it aids readability.
>> YMMV.
>>
>>> So is operator after line wrapping really a tomcat standard?
>>
>> operator before line wrapping is the direction the code is heading in and
>> the direction I think it should continue to head.
>>
> 
> My personal preference is that the new code formatting were more or
> less consistent with the rest of the file.

+1

> Trying to enforce a style here goes nowhere: such changes cannot be
> backported to TC6, and you cannot limit checkstyle to check only files
> created after certain date.

Before any checkstyle check can be enabled, the whole code-base has to
be changed to conform to the check. This tends to be something I do when
I have spare 30 mins I can't do anything else in, I'm stuck somewhere
without internet connectivity or I just feel the need to do something
fairly mindless for a while.

I usually add the checks I am thinking of working on to the checksyle
file in advance of doing the work - commented out with an indication of
the current number of failures - to give folks a chance to comment.

> If you have some "long string" that occupies all space up to position
> 79, forcing some operator after it to stay on the same line
> effectively increases its length by several chars and will cause the
> whole string to be placed on the new line. It just wastes space and
> becomes ugly.

+1. Line length is an area I am becoming increasingly happy to be
flexible. Aim for 80 but if 81 or 82 (or anything < ~90) makes the code
more readable then I'd be fine with it.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message