tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Date Tue, 07 Dec 2010 13:35:32 GMT
On 07/12/2010 13:28, Mark Thomas wrote:
> On 07/12/2010 12:29, Felix Schumacher wrote:
>> Am Montag, den 06.12.2010, 21:22 +0000 schrieb Mark Thomas:
>>> That indenting is now misleading (it was fine before) and the operator
>>> is still at the beginning of the line.
>> I just made a quick lookup for usage of (&&) operator at the end of line
>> versus (&&) operator at the beginning of the next line. It seems that
>> usage has changed between tomcat 6 and trunk.
>
> For the stats to be meaningful you'd need to look at all the possible
> operators, not just &&. That said, I suspect you'll see a similar thing,
> a gradual shift towards operator before line wrapping

Based on the Checkstyle error count for Tomcat 7:
operator before new line 2022
operator after new line  1077

So there is a preference for operator before but there are plenty of 
counter examples.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message