tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1042786 - in /tomcat/trunk/java/org/apache: catalina/core/ catalina/loader/ tomcat/util/threads/
Date Mon, 06 Dec 2010 21:22:03 GMT
On 06/12/2010 20:49, slaurent@apache.org wrote:
> Author: slaurent
> Date: Mon Dec  6 20:49:14 2010
> New Revision: 1042786
> 
> URL: http://svn.apache.org/viewvc?rev=1042786&view=rev


> @@ -63,7 +72,7 @@ public class ThreadLocalLeakPreventionLi
>          try {
>              Lifecycle lifecycle = event.getLifecycle();
>              if (Lifecycle.AFTER_START_EVENT.equals(event.getType())
> -                    && lifecycle instanceof Server) {
> +                && lifecycle instanceof Server) {
>                  // when the server starts, we register ourself as listener for
>                  // all context
>                  // as well as container event listener so that we know when new

That indenting is now misleading (it was fine before) and the operator
is still at the beginning of the line.


> -            log.error("Exception processing event " + event, e);
> +            String msg =
> +                sm.getString(
> +                    "threadLocalLeakPreventionListener.lifecycleEvent.error",
> +                    event);
> +            log.error(msg, e);

More auto formatting "helpfulness" by the look of it. No reason for
String msg = sm.getString(
not to be on one line.

If we can pull some Eclipse settings together to help folks with this
that would be great.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message