tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/
Date Sun, 05 Dec 2010 18:10:15 GMT
On 05/12/2010 17:50, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:markt@apache.org] 
>> Subject: Re: svn commit: r1041892 - in /tomcat/trunk:
>> java/org/apache/catalina/connector/test/org/apache/
>> catalina/connector/ webapps/docs/ webapps/docs/config/
> 
>>> +    public String getParseBodyMethods()
>>> +    {
>>> +        return (this.parseBodyMethods);
>>> +    }
>> The Tomcat code style is to have brackets at the end of the previous line.
> 
> And there's no reason to put parentheses around a return value.
> 
>>> +        if(methodSet.contains("TRACE"))
>>> +            throw new IllegalArgumentException("TRACE method MUST NOT 
>>>                   include an entity (see RFC 2616 Section 9.6)");
>> This should use the StringManager for i18n support.
> 
> Also needs a space after the if.
> 
> Is there a convention for line length,

Max of 80 (not always adhered to).

> and how to handle long constant strings that aren't controlled by the StringManager?
Static finals with appropriate visibility depending on if they need to
be re-used.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message