tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ test/org/apache/tomcat/util/net/ webapps/docs/
Date Fri, 03 Dec 2010 18:19:19 GMT
On 12/03/2010 06:58 PM, Mark Thomas wrote:
>>
>> Think that single eg. EndpointState enum will cover all the
>> states during start(),pause(),resume(),stop() replacing multiple
>> booleans (at least running and paused) with a single enum.
>>
>>
>> WDTYT?
>
> What we really need is the Lifecycle stuff that is in Catalina. We can't
> use that directly since that would create a dependency from the
> connectors to Catalina.
>

A bit complex to do initially, but might offer more
fine grained lifecycle management.

>
> Regardless of the above, I think the answer to bug 50360 is a bindOnInit
> property.
> If true, socket is bound on init() and released on destroy()
> If false, socket is bound on start() and released on stop()
>
> Question is, should the default be true (as current, works for jsvc,
> issues when embedding) or false (change from current, breaks jsvc, works
> when embedding). I'm leaning towards a default of true.
>

Well, breaking default means regression.
If started via Bootstrap default should be bindOnInit=true
50360 doesn't use Bootstrap, so default can be false, and
Bootstrap can set it to true.


Regards
-- 
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message